Skip to content

MILAB-7194: warn about blocks missing data of this block - #137

Merged
AStaroverov merged 6 commits into
mainfrom
MILAB-7194_column-value-refs
Nov 6, 2026
Merged

AStaroverov merged 6 commits into
mainfrom
MILAB-7194_column-value-refs

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

The block warns when blocks below it use its data and that data is gone or not produced yet.

  • UI (ui/src/pages/MetadataPage.vue, ui/src/pages/DatasetPage.vue, every page of the block): <PlBlockDependencies />. It reads the column links the app computes and shows nothing while every link is fine. When another block uses an output this block does not export, values this block no longer has, or data of this block before it has been run, it shows a warning naming those blocks, with advice to add the missing data or run the block; block names open the block.
  • Model (model/src/args_issues.ts): the dataset and multiplexing-rule checks moved from a throw in args() to argsIssues(), as in the other blocks of this change. args() now always builds args; every issue is an error, so Run stays disabled exactly when it did before, with the same messages.
  • SDK. model / ui-vue 1.88.0, workflow-tengo 6.20.0; vue 3.5.44, which that SDK requires. One file is reformatted for the newer oxfmt.

Checked: forced build 13/13, model tests 13, ui tests 82, tengo tests 8. Not run: the block tests on a live backend.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable defects were established.

Summary

Adds downstream dependency warnings to the metadata and dataset pages. Moves run checks from throws in args() to errors returned through argsIssues().

  • Metadata and dataset pages show when other blocks lose data they use.
  • The model reports input problems separately from building run arguments.
  • Workspace tools use newer SDK versions, and the rule table keeps its editing behavior.

Important touched types:

  • ArgsIssue: An SDK issue reported for the current arguments. Dataset and multiplexing checks now return this type.
  • BlockData: The saved datasets, metadata, samples, and import settings. The new blockArgsIssues() reads it; its shape is unchanged.
  • BlockArgs: The datasets, metadata, and sample labels passed to a run. Its shape is unchanged; args() now builds it without throwing.
  • MultiplexingRuleIssue: A barcode-rule issue with a message, severity, and dataset details. Its shape is unchanged; all returned issues are converted into one ArgsIssue with severity "error".

Verification: Source review only. Tests and visual checks were not run because dependencies were not installed. Live-backend behavior was not verified.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  D[Saved block data] --> A[Build run arguments]
  D --> V[Check datasets]
  V -->|Dataset issue| E[Return error]
  V -->|Datasets pass| M[Check multiplexing rules]
  M -->|Any issue| E
  M -->|No issues| N[Return no issues]
  E --> I[argsIssues]
  N --> I
Loading

Reviews (3) · Last reviewed commit: "MILAB-7194: describe the alert on every ..." · Reviewed by Greptile

args() builds args from whatever is configured and argsIssues() says what keeps the block from
running: a dataset without data and invalid multiplexing rules are reported as issues instead of
thrown, so the app sees the block's args while it is still being set up.
@AStaroverov
AStaroverov force-pushed the MILAB-7194_column-value-refs branch from c4140b4 to da4c5b5 Compare October 22, 2026 17:56
@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

@dbolotin
dbolotin force-pushed the MILAB-7194_column-value-refs branch from da4c5b5 to 80d06ed Compare October 31, 2026 09:41
@AStaroverov

Copy link
Copy Markdown
Contributor Author

@greptileai

@AStaroverov
AStaroverov added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 88d89b9 Nov 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant