Repository navigation
MILAB-7194: warn about blocks missing data of this block - #137
Merged
Merged
Conversation
args() builds args from whatever is configured and argsIssues() says what keeps the block from running: a dataset without data and invalid multiplexing rules are reported as issues instead of thrown, so the app sees the block's args while it is still being set up.
AStaroverov
force-pushed
the
MILAB-7194_column-value-refs
branch
from
October 22, 2026 17:56
c4140b4 to
da4c5b5
Compare
Contributor
Author
dbolotin
force-pushed
the
MILAB-7194_column-value-refs
branch
from
October 31, 2026 09:41
da4c5b5 to
80d06ed
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block warns when blocks below it use its data and that data is gone or not produced yet.
ui/src/pages/MetadataPage.vue,ui/src/pages/DatasetPage.vue, every page of the block):<PlBlockDependencies />. It reads the column links the app computes and shows nothing while every link is fine. When another block uses an output this block does not export, values this block no longer has, or data of this block before it has been run, it shows a warning naming those blocks, with advice to add the missing data or run the block; block names open the block.model/src/args_issues.ts): the dataset and multiplexing-rule checks moved from a throw inargs()toargsIssues(), as in the other blocks of this change.args()now always builds args; every issue is an error, so Run stays disabled exactly when it did before, with the same messages.Checked: forced build 13/13, model tests 13, ui tests 82, tengo tests 8. Not run: the block tests on a live backend.


Confidence Score: 5/5
The PR appears safe to merge; no actionable defects were established.Summary
Adds downstream dependency warnings to the metadata and dataset pages. Moves run checks from throws in
args()to errors returned throughargsIssues().Important touched types:
ArgsIssue: An SDK issue reported for the current arguments. Dataset and multiplexing checks now return this type.BlockData: The saved datasets, metadata, samples, and import settings. The newblockArgsIssues()reads it; its shape is unchanged.BlockArgs: The datasets, metadata, and sample labels passed to a run. Its shape is unchanged;args()now builds it without throwing.MultiplexingRuleIssue: A barcode-rule issue with a message, severity, and dataset details. Its shape is unchanged; all returned issues are converted into oneArgsIssuewith severity"error".Verification: Source review only. Tests and visual checks were not run because dependencies were not installed. Live-backend behavior was not verified.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD D[Saved block data] --> A[Build run arguments] D --> V[Check datasets] V -->|Dataset issue| E[Return error] V -->|Datasets pass| M[Check multiplexing rules] M -->|Any issue| E M -->|No issues| N[Return no issues] E --> I[argsIssues] N --> IReviews (3) · Last reviewed commit: "MILAB-7194: describe the alert on every ..." · Reviewed by Greptile